Bugzilla – Full Text Bug Listing
|Summary:||Rephrase rdesktop message of protocol negotiation and credssp|
|Product:||ThinLinc||Reporter:||Peter Åstrand <email@example.com>|
|Component:||| rdesktop (deprecated)||Assignee:||Henrik Andersson <firstname.lastname@example.org>|
|Status:||CLOSED FIXED||QA Contact:||Bugzilla mail exporter <email@example.com>|
This is problem #1, split off bug 4347. Currently, if you don't get SSL, rdesktop prints this: WARNING: RDP protocol negotiation failed with reason: SSL not allowed by server (error 0x2), WARNING: retrying without negotiation using plain RDP protocol. As Henrik and I have discussed, we should probably rephrase this as some kind of informational message, that doesn't sound all that severe. One line is probably enough. We could also consider printing the selected method even SSL is selected, so that you always sees the selected method.
Commit r1680 upstream adds a more informational message about the protocol negotitation, also as oneliner. Also a message was added for which protocol that was negotiated and used for connection establishment.
I did review the logging to the console in cssp.c and it does look good imho, only questionable string is the following one: ERROR: CredSSP: Initialize failed, do you have correct kerberos tgt initialized ? Which is presented if CredSSP+Kerberos are negotiatied and a tgt is missing any suggestions ?
Testing of this bug is done with test description of bug 2571, there has been some changes in connection flow which affects this bug.