Bugzilla – Full Text Bug Listing
|Summary:||SSH Banner is displayed twice|
|Product:||ThinLinc||Reporter:||Peter Åstrand <firstname.lastname@example.org>|
|Component:||Client||Assignee:||Samuel Mannehed <email@example.com>|
|Status:||CLOSED FIXED||QA Contact:||Bugzilla mail exporter <firstname.lastname@example.org>|
SSH allows you to display a "banner" when logging in, for example by adding this to sshd_config: Banner /etc/issue The TL client has support for displaying such a banner as a dialog box. However, since you are connecting with SSH twice, the banner will also be displayed two times, which may be confusing for the end user. we could consider displaying the banner only when connecting to the master, or the agent. Or, we could avoid the second banner if it has the same contents as the previous one.
Tests on Fedora 27 indicate that the fix works well.
There is a missing entry in release note for this fix.
Reopening since we have decided to consider the case where there are two different SSH banners, one on the master and one on the agent. In this case we want to display both of them. The only case where we hide a SSH banner is when the one from the master and the agent are identical.
Fixed now. I have tested using two Ubuntu 16.04 servers. The test cases are: * only banner on agent * only banner on master * identical banners on agent and master * different banners on agent and master