Bugzilla – Full Text Bug Listing
|Summary:||Resize support for the HTML5 Client|
|Product:||ThinLinc||Reporter:||Peter Åstrand <firstname.lastname@example.org>|
|Component:||Web Access||Assignee:||Samuel Mannehed <email@example.com>|
|Status:||CLOSED FIXED||QA Contact:||Bugzilla mail exporter <firstname.lastname@example.org>|
|Bug Depends on:||4648|
Implements the resize support functionality
fixes some errors in the logic from the first patch
Currently, the HTML5 client will adapt its canvas size to the current server side size of the session. Newly created sessions will have a size determined by /vsmagent/default_geometry. This is different from how the native client works: 1) It will resize the remote session to the preferred size set by the client side. 2) If "Resize remote session to the local window" is activated, it will dynamically resize the remote session when the size of the local window is changed. We should implement support for both these features in the HTML5 client.
> 1) It will resize the remote session to the preferred size set by the client > side. Initial size issue moved to bug 4648.
There is a pullrequest upstream for auto scaling feature, it does not fullfill requirements but it could be polished: https://github.com/kanaka/noVNC/pull/117
Created an attachment (id=478) [details] Implements the resize support functionality Fixed in the attached resizesupport.patch Made a pull request to the noVNC project on github: https://github.com/kanaka/noVNC/pull/271
Created an attachment (id=479) [details] fixes some errors in the logic from the first patch I fixed some errors in the logic and some indentation from the first patch. Also pushed into the same pull request on the noVNC project.
Updated in revision 27600. Note that my commit-message in revision 27593 is wrong: I wrote "Fixes bug 4648" while it actually fixes this bug, 4642.
There is a problem when trying to resize the viewport on mobile devices, reopening.
Viewport problem fixed in 27874.
There is still a slight problem when resizing the session on an iPad: 1) Start a session in landscape mode 2) Rotate screen to portrait, and then back to landscape again The new landscape session appears to have the correct size, but incorrect alignment - the top of the session is obscured slightly by the top NoVNC bar, and there is a few pixels of blank space at the bottom of the browser. Re-opening for discussion.
The alignment problem in Safari has nothing to do with this bug, it seems like iOS 7 has introduced a new bug/behavior which is the cause of the alignment problem. Opened bug 4868 for that.