Bugzilla – Full Text Bug Listing
|Summary:||Web Access keyboard code is needlessly complex|
|Product:||ThinLinc||Reporter:||Pierre Ossman <email@example.com>|
|Component:||Web Access||Assignee:||Pierre Ossman <firstname.lastname@example.org>|
|Status:||NEW||QA Contact:||Bugzilla mail exporter <email@example.com>|
|Bug Depends on:|
The HTML keyboard code is very complex and fragile, making it difficult to do any fixes or improvements to it. It has several problems: a) It is overly abstracted, with a complex pipeline model even though the steps in the pipeline are fixed. The steps aren't even independent of each other. b) The code has grown organically as a series of individual fixes and lacks an overall algorithm. c) Large parts of the code is there to deal with old browsers that aren't in use and do not fulfil noVNC's other requirements anyway. A major cleanup is needed.
One symptom of this is that when fixing support for Unicode characters (needed for many virtual keyboards), Enter and Backspace on IE/Edge stopped working: https://github.com/novnc/noVNC/issues/734
(In reply to comment #1) > One symptom of this is that when fixing support for Unicode characters (needed > for many virtual keyboards), Enter and Backspace on IE/Edge stopped working: > > https://github.com/novnc/noVNC/issues/734 The code that caused this was reverted in r32158. When the PR below is merged and we are going to include it in thinlinc, we need to revert the above commit. https://github.com/novnc/noVNC/pull/766
We decided to not do this right now.
(In reply to comment #2) > > https://github.com/novnc/noVNC/pull/766 This PR seems to solve most of the issues in bug 5135, reducing them to just a handful specific things.