Bug 2338 - unfsd's error messages aren't getting logged
Summary: unfsd's error messages aren't getting logged
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: pre-1.0
Hardware: PC Linux
: P2 Normal
Target Milestone: 4.10.1
Assignee: Pierre Ossman
URL:
Keywords: prosaic
Depends on:
Blocks:
 
Reported: 2007-02-06 17:27 CET by Pierre Ossman
Modified: 2019-06-11 10:55 CEST (History)
0 users

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2007-02-06 17:27:35 CET
For some strange reason the error messages from unfsd aren't being written to
tlclient.log. A successful startup shows up, but not one where there is a syntax
problem in the exports file. Both cases write to stdout, so it is very odd that
one works and the other doesn't.
Comment 1 Pierre Ossman cendio 2019-06-10 16:17:14 CEST
This is caused by buffering issues. We don't set up buffering until _after_ we've parsed everything. Until then stdout is fully buffered (since it is not a tty for us).

It's even worse on Windows where we never get any log data since stdout and stderr are both always fully buffered (since Windows doesn't support line buffering).
Comment 3 Pierre Ossman cendio 2019-06-10 16:19:59 CEST
Works better now.

I'm not sure how to get an invalid export file except with a custom build of tlclient.bin.

Windows should be easy to test though as we didn't get anything at all there before.
Comment 4 Peter Åstrand cendio 2019-06-11 10:55:21 CEST
Works on Linux with custom tlclient build:

2019-06-11T10:49:56: unfsd: UNFS3 unfsd 0.9.23 (C) 2009, Pascal Schmidt <unfs3-server@ewetel.net>
2019-06-11T10:49:56: unfsd: Warning: unknown exports option `nsecure' ignored
2019-06-11T10:49:56: Last line was repeated 1 time(s).
2019-06-11T10:49:56: unfsd: /tmp: ip 127.0.0.1 mask 255.255.255.255 options 12
2019-06-11T10:49:56: unfsd: /run/media/astrand: ip 127.0.0.1 mask 255.255.255.255 options 12

Works on Windows:

2019-06-11T10:51:33: unfsd: UNFS3 unfsd 0.9.23 (C) 2009, Pascal Schmidt <unfs3-server@ewetel.net>
2019-06-11T10:51:33: unfsd: /d: ip 127.0.0.1 mask 255.255.255.255 options 28
2019-06-11T10:51:33: unfsd: /c/Users/cendio.LAB/Documents: ip 127.0.0.1 mask 255.255.255.255 options 28
2019-06-11T10:51:33: unfsd: /g: ip 127.0.0.1 mask 255.255.255.255 options 28
2019-06-11T10:51:33: unfsd: /f: ip 127.0.0.1 mask 255.255.255.255 options 28
2019-06-11T10:51:33: unfsd: /c/Users/cendio.LAB/Desktop: ip 127.0.0.1 mask 255.255.255.255 options 28

Note You need to log in before you can comment on or make changes to this bug.