Bug 3513 - Client link kits fail to build in various ways
Summary: Client link kits fail to build in various ways
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: 3.0.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 11:32 CEST by Peter Åstrand
Modified: 2023-06-19 13:18 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Peter Åstrand cendio 2010-05-04 11:32:47 CEST
I have a feeling that our tlclient linkkits are not really working in practice. Part of the problem is that we have a separate Makefile.linkkit that we are not updating very often. Perhaps we can find a better solution.
Comment 1 Peter Åstrand cendio 2013-11-04 10:15:49 CET
Also, there's no linkkit for 64-bit Linux.
Comment 2 Pierre Ossman cendio 2014-10-15 13:09:34 CEST
An no linkkits for the ARM clients.
Comment 3 Pierre Ossman cendio 2015-10-29 13:23:54 CET
And no linkkits for pcsctun.
Comment 4 Pierre Ossman cendio 2015-10-29 13:34:04 CET
Linkkits also don't actually work:

> g++ -o tlclient.bin  tlclient.a localename.o neon/src/libneon.a xmlrpc++/libXmlRpc.a XmuClientWin.o  `fltk-config --use-images --ldflags`  -lXxf86misc -lXext -ltasn1 -ltre
> /bin/sh: fltk-config: command not found
> /usr/bin/ld: tlclient.a(tlclient_tlcontrol.o): undefined reference to symbol 'XkbFreeKeyboard'

> x86_64-apple-darwin10-g++ -o tlclient  tlclient.a localename.o neon/src/libneon.a xmlrpc++/libXmlRpc.a `fltk-config --use-images --ldflags` -ltre -liconv
> /bin/sh: fltk-config: command not found
> ld: in neon/src/libneon.a, archive has no table of contents

> checking for library containing socket... not found
> configure: error: could not find library containing socket
> make: *** [neon/src/libneon.a] Error 1
(win32)
Comment 5 Henrik Andersson cendio 2016-05-20 13:58:23 CEST
Building on Fedora 24 results in:

> g++ -o tlclient.bin  tlclient.a localename.o neon/src/libneon.a xmlrpc++/libXmlRpc.a XmuClientWin.o  `fltk-config --use-images --ldflags` -lXxf86misc -lXext -ltasn1 -ltre
> /usr/bin/ld: tlclient.a(tlclient_pkcs11.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
> /usr/lib64/libdl.so.2: error adding symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> Makefile:45: recipe for target 'tlclient.bin' failed
Comment 6 Henrik Andersson cendio 2016-05-20 14:00:13 CEST
(In reply to comment #5)
> Building on Fedora 24 results in:
> 
> > g++ -o tlclient.bin  tlclient.a localename.o neon/src/libneon.a xmlrpc++/libXmlRpc.a XmuClientWin.o  `fltk-config --use-images --ldflags` -lXxf86misc -lXext -ltasn1 -ltre
> > /usr/bin/ld: tlclient.a(tlclient_pkcs11.o): undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
> > /usr/lib64/libdl.so.2: error adding symbols: DSO missing from command line
> > collect2: error: ld returned 1 exit status
> > Makefile:45: recipe for target 'tlclient.bin' failed

Adding dl library the following give result:

> g++ -o tlclient.bin  tlclient.a localename.o neon/src/libneon.a xmlrpc++/libXmlRpc.a XmuClientWin.o  `fltk-config --use-images --ldflags` -lXxf86misc -lXext -ltasn1 -ltre -ldl
/usr/bin/ld: tlclient.a(tlclient_tlcontrol.o): undefined reference to symbol 'XGetPointerControl'
Comment 7 Pierre Ossman cendio 2016-11-01 10:44:38 CET
Recreating the .o files after the fact can be very difficult so we want to at least make sure we ship all the linkkits. Fixing the instructions and Makefile may be moved to a later bug.

We should also have a look at the test instructions for these linkkits so testers know which kits are expected and why we have them.
Comment 8 Samuel Mannehed cendio 2016-12-06 12:27:34 CET
See bug 6104 for problems with tlstunnel linkkit
Comment 10 Pierre Ossman cendio 2021-12-29 13:24:03 CET
We also still include libXxf86misc on the link line, even though that should have been removed in r34768 for bug 5325.
Comment 14 Pierre Ossman cendio 2023-06-19 13:18:13 CEST
Shipping the missing link kits is a much smaller fix than everything else, so move that to a separate bug (bug 8175).

Note You need to log in before you can comment on or make changes to this bug.