Bug 4621 - vsmagent fails to create session if it can't check the existence of $HOME
Summary: vsmagent fails to create session if it can't check the existence of $HOME
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Agent (show other bugs)
Version: 4.0.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.1.1
Assignee: Karl Mikaelsson
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2013-04-25 13:36 CEST by Aaron Sowry
Modified: 2013-10-29 13:01 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Sowry cendio 2013-04-25 13:36:07 CEST 
For example, if $HOME/.. is not readable by root, then vsmagent will fail to create a session. Note that this is true even when /vsmagent/make_homedir=0.

The problem is in handler_reqsession.py:check_homedir() - here we check the existence of $HOME before we check the value /vsmagent/make_homedir, which means the function will always fail if $HOME can't be statted.
Comment 1 Karl Mikaelsson cendio 2013-10-02 13:37:03 CEST 
The big question here is if vsmagent should perform home directory checks at all unless it's told to create a new homedir. I'm thinking tl-session/tl-xinit should handle this.
Comment 2 Karl Mikaelsson cendio 2013-10-09 10:52:43 CEST 
(In reply to comment #1)
> The big question here is if vsmagent should perform home directory checks at
> all unless it's told to create a new homedir. I'm thinking tl-session/tl-xinit
> should handle this.

Bug 4831.
Comment 3 Karl Mikaelsson cendio 2013-10-09 12:53:21 CEST 
Comitted in r28012.
Comment 4 Karl Mikaelsson cendio 2013-10-09 16:25:25 CEST 
Works well enough.
Comment 5 Pierre Ossman cendio 2013-10-10 14:51:25 CEST 
Tested the following:

 1. Successful creating of missing home dir

 2. Failure because of NFS root squash:

2013-10-10 14:26:55 WARNING vsmagent: Failed to create /home/ossman/profile/foo: [Errno 13] Permission denied: '/home/ossman/profile/foo'

 3. Success with NFS root squash and make_homedir=0
Comment 6 Pierre Ossman cendio 2013-10-23 13:31:45 CEST 
Not working well on Solaris with its magical /home. It is throwing this:

2013-10-23 13:22:03 WARNING vsmagent: Failed to create /home/tluser: [Errno 89] Operation not applicable: '/home/tluser'

(errno 89 is ENOSYS)
Comment 7 Karl Mikaelsson cendio 2013-10-23 17:06:59 CEST 
(In reply to comment #6)
> Not working well on Solaris with its magical /home. It is throwing this:
> 
> 2013-10-23 13:22:03 WARNING vsmagent: Failed to create /home/tluser: [Errno 89]
> Operation not applicable: '/home/tluser'
> 
> (errno 89 is ENOSYS)

Fixed in r28069.
Comment 8 Pierre Ossman cendio 2013-10-29 13:01:52 CET 
The Solaris problem is now indeed solved. Also retested on Fedora 19 without any issues.
Note You need to log in before you can comment on or make changes to this bug.