Bug 4719 - Profile reordering does not work
: Profile reordering does not work
: ThinLinc
Web Administration
: trunk
: PC Unknown
: P2 Normal
: 4.1.1
Assigned To:
  Show dependency treegraph
Reported: 2013-06-24 10:02 by
Modified: 2013-10-24 10:59 (History)
Acceptance Criteria:



You need to log in before you can comment on or make changes to this bug.

Description From cendio 2013-06-24 10:02:57
If you press any of the "Reorder" buttons in the ThinLinc Web Administration,
nothing happens.
------- Comment #1 From cendio 2013-09-11 13:09:19 -------
This is because the re-order buttons are <input> tags of type "img", which
according to the HTML spec[1] do not send a "value" in their query; they send
the coordinates of the click on the image. Our server-side code looks for a
"value" key, and it's not finding one.

We could possibly reimplement the buttons as actual <button>s, containing an
<img> instead.

[1] http://www.w3.org/TR/html4/interact/forms.html#h-17.4.1
------- Comment #2 From cendio 2013-09-11 13:35:14 -------
------- Comment #3 From cendio 2013-10-11 09:23:44 -------
Tested using Chrome 30, Firefox 24 and IE11. Works as expected.
------- Comment #4 From cendio 2013-10-16 14:48:13 -------
They may work now, but they've been changed to much bigger buttons instead of
the smaller icons used before.
------- Comment #5 From cendio 2013-10-18 15:56:52 -------
Going back to an image control is difficult as we have to encode everything in
the "name" attribute. Possible, but messy. So the button approach is probably
the best solution, but we need to make sure it only renders the image. r28061
uses CSS to kill off the decorations provided by the browser.
------- Comment #6 From cendio 2013-10-21 13:21:58 -------
Had a quick look and am happy with the solution, resolving bug for Henrik to
------- Comment #7 From cendio 2013-10-21 14:07:21 -------
Im also happy with the change of appearance, and those buttons work as