Bug 4750 - thinlinc.ctccommon.get_tl_xvnc_processes uses hardcoded path /opt/thinlinc/libexec/Xvnc
Summary: thinlinc.ctccommon.get_tl_xvnc_processes uses hardcoded path /opt/thinlinc/li...
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.1.1
Assignee: Peter Åstrand
URL:
Keywords: aaron_tester, prosaic
Depends on:
Blocks:
 
Reported: 2013-07-15 08:37 CEST by Peter Åstrand
Modified: 2013-10-24 11:02 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2013-07-15 08:37:09 CEST 
See discussion on mailing list:

http://lists.cendio.se/pipermail/thinlinc-technical/2013-July/000344.html

Ideas for a solution:

1) Do not check the full path at all, but instead verify root ownership or something similar. 

2) Fetch the prefix dynamically. Probably needs this as an argument to get_tl_xvnc_processes then.
Comment 1 Peter Åstrand cendio 2013-09-12 14:59:17 CEST 
(In reply to comment #0)

> 2) Fetch the prefix dynamically. Probably needs this as an argument to
> get_tl_xvnc_processes then.

Fixed in 27873.
Comment 2 Henrik Andersson cendio 2013-10-21 10:52:57 CEST 
(In reply to comment #1)
> (In reply to comment #0)
> 
> > 2) Fetch the prefix dynamically. Probably needs this as an argument to
> > get_tl_xvnc_processes then.
> 
> Fixed in 27873.

Tested using following code:

python -c "import thinlinc.ctccommon; print thinlinc.ctccommon.get_tl_xvnc_processes()"

The commit fixes the issue partly using prefix.get_tl_prefix() which in its turn returns a hardcoded path to /opt/thinlinc and gives the following warning:

'Warning: -c uses get_tl_prefix() uninitialised'

However the main issue is solved and sessions are returned.
Comment 3 Henrik Andersson cendio 2013-10-21 11:03:02 CEST 
> Tested using following code:
> 
> python -c "import thinlinc.ctccommon; print
> thinlinc.ctccommon.get_tl_xvnc_processes()"
> 
> The commit fixes the issue partly using prefix.get_tl_prefix() which in its
> turn returns a hardcoded path to /opt/thinlinc and gives the following warning:
> 
> 'Warning: -c uses get_tl_prefix() uninitialised'
> 
> However the main issue is solved and sessions are returned.

This is good enough now when main issue is solved.
Comment 4 Henrik Andersson cendio 2013-10-21 11:17:34 CEST 
I missed the obvious thing in this bug, tester should test install ThinLinc under another installation prefix, as the orginal issue referenced on mailinglist is about.
Comment 5 Pierre Ossman cendio 2013-10-22 10:34:08 CEST 
There are a lot of other issues preventing ThinLinc from running in a custom path, so it's not meaningful to test that. What should be tested though is that the HTML 5 client works fine after this change.
Comment 6 Aaron Sowry cendio 2013-10-22 13:24:11 CEST 
(In reply to comment #5)
> There are a lot of other issues preventing ThinLinc from running in a custom
> path, so it's not meaningful to test that. What should be tested though is that
> the HTML 5 client works fine after this change.

Have been testing the HTML5 client without any issues, so closing this bug.
Note You need to log in before you can comment on or make changes to this bug.