Bug 5091 - $TLCOMMAND is mixed into the profile commands
Summary: $TLCOMMAND is mixed into the profile commands
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Karl Mikaelsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-14 13:54 CEST by Pierre Ossman
Modified: 2014-07-25 11:20 CEST (History)
0 users

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2014-04-14 13:54:05 CEST
Right now the handling of $TLCOMMAND is in tl-select-profile and tl-run-profile. It would probably be clearer if we separated it out from there so that "profile" is a more consistent concept in ThinLinc.

Problems to solve:

 - What if we want to show the intro text, even though we don't want it to show any profile choices? (this could be relevant even in other cases)

 - Do we want to make xstartup.default more complex, or do we want an intermediate script between xstartup.default and tl-run-profile?
Comment 1 Pierre Ossman cendio 2014-04-14 13:56:01 CEST
tl-run-profile should probably also be changed to take an argument instead of looking at $TLPROFILE when we do this. That would consistently keep the environment variable handling in the shell scripts.
Comment 2 Karl Mikaelsson cendio 2014-07-25 11:20:16 CEST
(In reply to comment #0)
>  - What if we want to show the intro text, even though we don't want it to show
> any profile choices? (this could be relevant even in other cases)

Splitting the intro text into a separate binary instead of keeping it inside tl-select-profile would enable us to remove the intro configuration entirely from profiles.hconf, which would be a good thing

With a separate binary for the intro we could also get rid of the show_intro configuration variable and just use the xstartup.d directory. This would also allow users more flexible configuration of when the intro is shown by putting custom script in xstartup.d rather than symlinks.

Note You need to log in before you can comment on or make changes to this bug.