Bug 5179 - vncconfig -set should accept more parameters
Summary: vncconfig -set should accept more parameters
Status: CLOSED WONTFIX
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: 4.2.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-03 13:51 CEST by Peter Åstrand
Modified: 2023-02-07 13:23 CET (History)
0 users

See Also:
Acceptance Criteria:


Attachments

Description Peter Åstrand cendio 2014-06-03 13:51:19 CEST
vncconfig -list shows a pretty long list of runtime parameter. Unfortunately, vncconfig -set only works on a few of them, since we have this in vncExtInit.cc:

  /*
   * Allow to change only certain parameters.
   * Changing other parameters (for example PAM service name)
   * could have negative security impact.
   */
  if (strncasecmp(param.buf, "desktop", 7) != 0 &&
      strncasecmp(param.buf, "AcceptPointerEvents", 19) != 0 &&
      (noclipboard || strncasecmp(param.buf, "SendCutText", 11) != 0) &&
      (noclipboard || strncasecmp(param.buf, "AcceptCutText", 13) != 0))
    goto deny;

We should accept a lot of parameters, at least MaxIdleTime et al. However, I'd say that probably we could have blacklist instead, or, as an alternative, disallow "almost everything" when running setuid. If not setuid, there's no point of disallowing runtime configuration, since it can be changed with gdb anyway...
Comment 1 Pierre Ossman cendio 2018-10-16 14:08:23 CEST
Upstream now has a bit more flexibility in the form of the "AllowOverride" setting, which controls what users can modify.
Comment 2 Pierre Ossman cendio 2023-02-07 13:23:17 CET
There are no clear use cases described here, only a suggestion for a technical solution. We can revisit this under a more specific bug once we know what problem we are trying to solve.

Note You need to log in before you can comment on or make changes to this bug.