www.cendio.com
Bug 5309 - bad/missing linkkit for tlstunnel
: bad/missing linkkit for tlstunnel
Status: CLOSED FIXED
: ThinLinc
Misc
: pre-1.0
: PC Unknown
: P2 Normal
: 4.8.0
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2014-10-15 13:34 by
Modified: 2017-03-20 16:54 (History)
Acceptance Criteria:


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From cendio 2014-10-15 13:34:45
We don't have linkkits for either x86 platform on the server bundle. There is
one kit named "linux", but it's just a copy of the Solaris file.
------- Comment #1 From cendio 2016-04-18 11:15:17 -------
It looks like this was caused in r26474 as part of bug 4132. We moved tlstunnel
from tladm to tlmisc but the top Makefile was only partially adjusted.
------- Comment #2 From cendio 2016-11-01 14:53:08 -------
(from comment on bug 3513)

Recreating the .o files after the fact can be very difficult so we want to at
least make sure we ship all the linkkits. Fixing the instructions and Makefile
may be moved to a later bug.

We should also have a look at the test instructions for these linkkits so
testers know which kits are expected and why we have them.
------- Comment #3 From cendio 2016-11-28 11:04:04 -------
(In reply to comment #1)
> It looks like this was caused in r26474 as part of bug 4132. We moved tlstunnel
> from tladm to tlmisc but the top Makefile was only partially adjusted.

I'd say that the problem was rather causes by a later commit:

------------------------------------------------------------------------
r30455 | hean01 | 2015-06-22 12:59:12 +0200 (mån, 22 jun 2015) | 5 lines

Rename linkkit package and targets.

Fix bug #3614 comment #16
----------------

In this commit, TLSTUNNEL_LINKKIT_LINUX_TGZ_NAME was renamed to
TLSTUNNEL_LINKKIT_I686_TGZ_NAME, but not all of Makefile was updated. 

As it is now, it's pure luck that the build succeeds. On my workstation, it
does not:

mkdir -p `dirname server-bundle/sources/thinlinc-wts-tools-open-sources.tar.gz`
cp windows-components/thinlinc-wts-tools-open-sources.tar.gz
server-bundle/sources/thinlinc-wts-tools-open-sources.tar.gz
mkdir -p `dirname server-bundle/sources/`
cp tlmisc/ server-bundle/sources/
cp: utesluter katalog "tlmisc/"
make: *** [server-bundle/sources/] Fel 1
------- Comment #5 From cendio 2016-12-05 13:34:38 -------
To summarize:

There should be linkkits for both i386 and x86_64 Linux, and they should
contain object files. Having working Makefiles are out of scope of this bug,
and in the case that they are broken, a new bug should be reported.
------- Comment #6 From cendio 2016-12-05 14:48:41 -------
tlstunnel objects are present in both linkkits:

> $ tar -xvzf tlstunnel-linkkit-i686.tar.gz
> tlstunnel-linkkit/
> tlstunnel-linkkit/libnettle.a
> tlstunnel-linkkit/Makefile
> tlstunnel-linkkit/libhogweed.a
> tlstunnel-linkkit/tlstunnel.o
> tlstunnel-linkkit/libtasn1.a
> tlstunnel-linkkit/libgnutls.a
> tlstunnel-linkkit/libgmp.a

> $ file tlstunnel-linkkit/tlstunnel.o
> tlstunnel-linkkit/tlstunnel.o: ELF 32-bit LSB relocatable, Intel 80386, version 1 (SYSV), not stripped

> $ rm -rf tlstunnel-linkkit

> $ tar -xvzf tlstunnel-linkkit-x86_64.tar.gz
> tlstunnel-linkkit/
> tlstunnel-linkkit/libnettle.a
> tlstunnel-linkkit/Makefile
> tlstunnel-linkkit/libhogweed.a
> tlstunnel-linkkit/tlstunnel.o
> tlstunnel-linkkit/libtasn1.a
> tlstunnel-linkkit/libgnutls.a
> tlstunnel-linkkit/libgmp.a
>
> $ file tlstunnel-linkkit/tlstunnel.o
> tlstunnel-linkkit/tlstunnel.o: ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
------- Comment #7 From cendio 2016-12-05 15:07:15 -------
I was unable to relink the object files for x86_64 on Fedora 24 - see bug 6104.
This was discussed, and found to be out of scope of this bug.

There are object files. Good enough.