Bug 5459 - Make vendordrop structure for websockify
Summary: Make vendordrop structure for websockify
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Samuel Mannehed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-05 11:46 CET by Samuel Mannehed
Modified: 2016-06-29 17:08 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Samuel Mannehed cendio 2015-03-05 11:46:48 CET
https://github.com/kanaka/noVNC/commit/6f5148648bd0e0ffa7ad00474c230f5f1ff4e39f

Websockify was removed from noVNC as of this commit. Currently we are running a quite old version of websocket.py which is the only file we use directly from the websockify project. We should set up so that we can do vendordrops from websockify just as we can with noVNC.

https://github.com/kanaka/websockify
Comment 1 Samuel Mannehed cendio 2015-06-18 13:43:21 CEST
There are files living in both noVNC and websockify upstreams and there is no official consensus yet as to which project owns which files. Due to this we don't think we would benefit from adding infrastructure for this atm.
Comment 2 Samuel Mannehed cendio 2016-06-20 15:00:57 CEST
This isn't true anymore. The Websockify project is now the only proper upstream for these files.
Comment 4 Samuel Mannehed cendio 2016-06-20 15:42:58 CEST
NEVER MIND! /webaccess/noVNC/include/websock.js still lives in both the noVNC project and Websockify.. There seems to be more shared files in include.
Comment 5 Peter Åstrand cendio 2016-06-29 14:04:58 CEST
It is correct that there's some confusion over files such as websock.js. However, for websocket.py, it is clear that the websockify project is the only upstream. This file is no longer a part of the noVNC project. It is also still true that we are using this file, and that we are lagging behind. This is suboptimal. This means that we are not getting bug fixes or work such as Python 3 compatibility. See https://github.com/kanaka/websockify/commits/master/websockify/websocket.py .

Without a vendordrop structure, it's also difficult to see our own changes. r31509 does some changes that have not been pushed upstream, though.

Note You need to log in before you can comment on or make changes to this bug.