Bug 5507 - Always show the viewport drag button on touch devices
Summary: Always show the viewport drag button on touch devices
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.5.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2015-04-24 14:20 CEST by Samuel Mannehed
Modified: 2015-09-25 13:56 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Samuel Mannehed cendio 2015-04-24 14:20:27 CEST
Currently, the viewport drag button (the hand) is only shown when the remote session is larger than the local window. This causes the ui elements in the control bar to move and change positions when this button is shown and hidden.

A better solution would probably be to always show the button but have it disabled instead when it currently is hidden.
Comment 1 Samuel Mannehed cendio 2015-06-16 22:36:40 CEST
The viewdrag button is the only button shown on the left hand side of the control bar on non-touch devices. Due to this I think the current behavior is good on non-touch devices.

On touch devices however, we don't want the GUI to "jump around". This is especially irritating when opening/closing the on-screen keyboard on Android devices since this will resize the viewport. Thus we want this button to be disabled/enabled instead of shown/hidden on such platforms.
Comment 2 Samuel Mannehed cendio 2015-06-17 10:24:11 CEST
Fixed in commit 30402.
Comment 3 Henrik Andersson cendio 2015-06-22 15:35:52 CEST
If panning state is selected and active while rotating the display which provokes a new resize, the button is disabled but the state is still active and mouse is not working as expected. Event the button is active state visually.
Comment 4 Samuel Mannehed cendio 2015-06-24 17:08:31 CEST
(In reply to comment #1)
> The viewdrag button is the only button shown on the left hand side of the
> control bar on non-touch devices. Due to this I think the current behavior is
> good on non-touch devices.

I have to correct myself here since non-touch devices never show the viewdrag button in ThinLinc's HTML5 client. The quoted statement is only true for noVNC. However since this became a non-question, the conclusion is still the same.


(In reply to comment #3)
> If panning state is selected and active while rotating the display which
> provokes a new resize, the button is disabled but the state is still active and
> mouse is not working as expected. Event the button is active state visually.

Fixed in commit 30494.

Keep Bug 5572 in mind while testing this.
Comment 5 Pierre Ossman cendio 2015-06-25 10:59:56 CEST
The hand is now always shown. Tested with Firefox on Android.
Comment 6 Pierre Ossman cendio 2015-08-11 15:47:51 CEST
(In reply to comment #3)
> If panning state is selected and active while rotating the display which
> provokes a new resize, the button is disabled but the state is still active and
> mouse is not working as expected. Event the button is active state visually.

I've also tested that this works as it should.

Note You need to log in before you can comment on or make changes to this bug.