More poor buffer management in the same theme as bug 5212. Any password with 32*n-2 characters in it will just hang. E.g. 30, 62 or 94 characters. The problem is that it fails to handle the case when the buffer was just big enough to contain the response. It will then assume it needs to read more, which of course never happens.
Created attachment 649 [details] Test pamtester password lengths. Wrote a script to test password lengths using pamtester.
Ran the test script against ThinLinc 4.4.0 and it hung at 30, 62, 94, 126... Updated ThinLinc to build 4898 and reran the script, it stalls on length 511 which i assume is another internal buffer constraint in pamtester due to any length >= 511 will hang pamtester.
(In reply to comment #5) > Ran the test script against ThinLinc 4.4.0 and it hung at 30, 62, 94, 126... > > Updated ThinLinc to build 4898 and reran the script, it stalls on length 511 > which i assume is another internal buffer constraint in pamtester due to any > length >= 511 will hang pamtester. Created bug 5658 for this issue.
Closing due to it works good as loon password is <=511 characters.
