www.cendio.com
Bug 7240 - server can override and monitor clipboard when the client is in the background
: server can override and monitor clipboard when the client is in the background
Status: CLOSED FIXED
: ThinLinc
Client platforms
: 1.3.1
: PC Unknown
: P2 Normal
: 4.10.0
Assigned To:
:
:
: 7158
:
  Show dependency treegraph
 
Reported: 2018-08-27 16:31 by
Modified: 2018-09-25 16:04 (History)
Acceptance Criteria:
* Changes to the server clipboard should not affect the local, client clipboard when the client doesn't have focus * Changes to the local, client clipboard should not affect the server clipboard when the client doesn't have focus * Any local clipboard changes that happens when not focused, should be updated to the server once the client gets focus


Attachments
Test program that injects data into selection and clipboard for testing. (813 bytes, text/x-csrc)
2018-09-17 16:00, Henrik Andersson
Details


Note

You need to log in before you can comment on or make changes to this bug.


Description From cendio 2018-08-27 16:31:53
Right now we always update the local clipboard if something changes on the
server. This is probably not what the user wants if the client is in the
background and not being interacted with.

Similarly we also send any clipboard changes from the client right away. This
is wasteful, and probably not a good idea to let the server know of each and
every selection (in the case of a Linux client).
------- Comment #1 From cendio 2018-08-27 16:34:27 -------
Upstream has changed things to only update the clipboard when focused:

https://github.com/TigerVNC/tigervnc/commit/be6909b3c03f61dab35c491b2a9dea0ffd2e5658
------- Comment #2 From cendio 2018-09-17 16:00:54 -------
Created an attachment (id=885) [details]
Test program that injects data into selection and clipboard for testing.
------- Comment #3 From cendio 2018-09-18 09:31:21 -------
> * Changes to the server clipboard should not affect the local,
>   client clipboard when the client doesn't have focus
>

Work as expected; Linux (x86_64), Mac Os 10.13, Windows 10

> * Changes to the local, client clipboard should not affect the
>   server clipboard when the client doesn't have focus
>

Work as expected; Linux (x86_64), Mac Os 10.13, Windows 10

> * Any local clipboard changes that happens when not focused,
> should be updated to the server once the client gets focus
>

Work as expected; Linux (x86_64), Mac Os 10.13, Windows 10
------- Comment #4 From cendio 2018-09-18 09:35:29 -------
Relasenote added in commit 33692.