Bug 7258 - cropped desktop name can result in garbled UTF-8
Summary: cropped desktop name can result in garbled UTF-8
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Pierre Ossman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-15 11:30 CEST by Pierre Ossman
Modified: 2018-10-16 13:21 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2018-10-15 11:30:57 CEST
(found while testing bug 5526)

We crop the desktop name before we use it as a window title in order to make sure that "ThinLinc Client" is always visible. However we do this cropping on a byte level, which can result in an invalid UTF-8 sequence if we manage to slice a character in half. On X11 this results in the system assuming the title is in latin 1 and just gives us UTF-8 noise. Not sure what will happen on Windows or macOS, but it probably won't be the expected behaviour.

For the same reasons we are also overly aggressive with the cropping as we set the limit on the assumption that each byte was one character.

Note You need to log in before you can comment on or make changes to this bug.