Bug 7269 - macos client bundle name isn't translated
Summary: macos client bundle name isn't translated
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client platforms (show other bugs)
Version: 1.3.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.14.0
Assignee: William Sjöblom
URL:
Keywords: nikle_tester, ossman_tester, relnotes
Depends on:
Blocks:
 
Reported: 2018-11-01 14:55 CET by Pierre Ossman
Modified: 2021-09-07 16:20 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2018-11-01 14:55:54 CET 
The macOS bundle name ("app name") is not properly translated and will always say "ThinLinc Client". This is wrong as it should be translated when the system language is one of our supported languages.

Info here on how to localize the plist file (where the name is stored):

https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/AboutInformationPropertyListFiles.html
Comment 1 Pierre Ossman cendio 2021-08-27 11:05:03 CEST 
We actually have translations, but only for CFBundleName, not CFBundleDisplayName. Perhaps this worked at some point as macOS prioritised things differently?
Comment 3 William Sjöblom cendio 2021-09-03 08:27:25 CEST 
The localized application name is now displayed. Tested Jenkins client build #2181 on macOS 11.5.2 with its display language set to Swedish. The Swedish name ("ThinLinc-klient") now shows up in Finder under "Applications", in Launch Pad, and in the bottom dock.
Comment 4 Pierre Ossman cendio 2021-09-06 13:55:59 CEST 
Seems to work fine. Tested Swedish, Russian and Brazilian Portuguese. Also tested Japanese and saw that it correctly fell back to English for unknown languages.

Release notes are missing though.
Comment 6 William Sjöblom cendio 2021-09-07 13:21:46 CEST 
Release notes have now been added.
Comment 7 Niko Lehto cendio 2021-09-07 16:20:26 CEST 
Release notes looks good!
Note You need to log in before you can comment on or make changes to this bug.