Our last vendor drop was 2018-09-21. We need to get back in sync before we can start developing new things for TigerVNC. 6fba8ca7e7c896d3758b8401b35cee0849778fbd seems to be the last commit we got from upstream.
Seems to work after upgrade. Some detailed testing is needed though: For X11 libraries: * Nothing special. Will be covered by other tests. For libpng: * Check that branding still works in the client For FLTK (on every OS): * Fullscreen (both single and dual monitor) * Mouse cursor * Keyboard grab * Graphics performance (also on bug 7290) * Input method handling (that it is disabled when using session) For TigerVNC: * Shadowing * Server timeouts (e.g. MaxIdleTimeout)
Tested against a RHEL 8 server on clients running Fedora 31, macOS 10.15, Window 10. libpng: ✓ Branding FLTK: Scenario | Windows | macOS | linux | --------------------------------------------+---------+-------+-------+ Fullscreen (both single and dual monitor) | ✓ | ✓* | ✓ | --------------------------------------------+---------+-------+-------+ Mouse cursor | ✓ | ✓ | ✓ | --------------------------------------------+---------+-------+-------+ Keyboard grab | ✓ | ✓ | ✓ | --------------------------------------------+---------+-------+-------+ Graphics performance (also on bug 7290) | ✓ | ✓ | ✓ | --------------------------------------------+---------+-------+-------+ Input method handling (disabled in session) | ✓ | ✓ | ✗** | --------------------------------------------+---------+-------+-------+ TigerVNC: ✓ Shadowing ✓ Server timeouts * macOS works correctly the first time you launch the client in full screen on both monitors. However, if you disable full screen on both monitors and enable it again it will not work. One screen will be black. Upgrade of FLTK probably broke this since it worked fine on 4.10.1 client. ** This is probably a bug in FLTK. See https://www.fltk.org/str.php?L3502+P0+S-2+C0+I0+E0+V1.3%25+Q for more info.
Input methods issue moved to bug 7465.
The fullscreen issue seems to have been caused by this commit: https://github.com/fltk/fltk/commit/39bb0bf488dc1d9051b6eec719df1ac17ca88bc9 Reported upstream here: https://github.com/fltk/fltk/issues/51
(In reply to comment #7) > > * macOS works correctly the first time you launch the client in full screen on > both monitors. However, if you disable full screen on both monitors and enable > it again it will not work. One screen will be black. Upgrade of FLTK probably > broke this since it worked fine on 4.10.1 client. > This issue is now fixed on macOS. Tested with tlclient version 6365 and it works fine. Also tested tlclients on Windows 10 and Fedora 31 and this fix didn't affect these.
The issues found when upgrading FLTK (mentioned in comment #7) is now fixed so closing this for now.
It seems MaxDisconnectionTime stopped working in this vendor drop. Also reported upstream: https://github.com/TigerVNC/tigervnc/issues/1042
Should be fixed now. Need to retest the various timeouts.
Tested the lifetime timeouts on Fedora 31 clients against both an RHEL 8 and a Ubuntu 20.04 running server build 6506 with tl-vnc build 6508. I tested every timeout option: * MaxDisconnectionTime s * MaxConnectionTime s * MaxIdleTime s These seem to work fine on both servers.
