Bug 7416 - pressing both shift keys on Windows wedges shift state
Summary: pressing both shift keys on Windows wedges shift state
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.11.0
Assignee: Samuel Mannehed
URL:
Keywords: relnotes, upstream
Depends on: 5229
Blocks: 3523
  Show dependency treegraph
 
Reported: 2019-10-31 11:18 CET by Pierre Ossman
Modified: 2019-11-04 17:16 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2019-10-31 11:18:24 CET
Pressing both the left and right shift key on Windows and then releasing them results in shift getting stuck. This is an OS level bug where one release event goes missing. We have implemented a workaround in TigerVNC (see bug 5229), but not in Web Access.
Comment 3 Samuel Mannehed cendio 2019-11-04 17:11:31 CET
Fixed with vendordrop.
Comment 4 Samuel Mannehed cendio 2019-11-04 17:11:52 CET
Verified that the problem existed in Chrome 78 on Windows 10 with build 6285:

 Shift L down -> Shift R down -> Shift L up -> Shift R up

resulted in the session to:

 Shift L down -> Shift R down -> Shift R up

After upgrading to a fixed webaccess package, I have verified that it's better now with Chrome, Firefox, and IE, I get:

 Shift L down -> Shift R down -> Shift L up -> Shift R up

results in the session to:

 Shift L down -> Shift R down -> Shift R up -> Shift L up

Note that the order of key releases is not perfect above, the reality is that we don't get the "Shift L up" until Shift R has been released. We don't get any events from windows at all, so this is the best we can do. At least it doesn't get stuck now.

Edge, however, does seem to have proper detection for this at the moment and doesn't need the workaround. Our workaround makes things worse actually, we get:

 Shift L down -> Shift R down -> Shift L up -> Shift R up-> Shift R down -> Shift R up

But, Edge is on it's way to the grave so we have decided to not care about this for now.

Note You need to log in before you can comment on or make changes to this bug.