Bug 3331 - Add support for WTS font smoothing (ClearType)
Summary: Add support for WTS font smoothing (ClearType)
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: 3.0.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.8.0
Assignee: Henrik Andersson
URL:
Keywords: relnotes, samuel_tester
Depends on:
Blocks: 2036
  Show dependency treegraph
 
Reported: 2009-11-23 16:14 CET by Peter Åstrand
Modified: 2017-03-20 17:09 CET (History)
3 users (show)

See Also:
Acceptance Criteria:


Attachments
Side-by-side comparison of screenshots from Windows 2008R2 Server (90.46 KB, image/png)
2016-12-06 15:14 CET, Thomas Nilefalk
Details
Side-by-side comparison of screenshots from Windows 2012 Server (132.90 KB, image/png)
2016-12-06 15:15 CET, Thomas Nilefalk
Details
Side-by-side comparison of screenshots from Windows 2008R2 Server (281.31 KB, image/png)
2016-12-06 16:21 CET, Thomas Nilefalk
Details
Side-by-side comparison of screenshots from Windows 2012 Server (281.14 KB, image/png)
2016-12-06 16:22 CET, Thomas Nilefalk
Details

Comment 1 Peter Åstrand cendio 2009-11-23 16:19:01 CET
According to http://en.wikipedia.org/wiki/Remote_Desktop_Protocol, this feature was introduced with RDP 6.0 in 2006. http://blogs.sepago.de/helge/2008/07/08/finally-font-smoothing-over-rdpica-on-server-2003/ is also very interesting. And this page:

http://katastrophos.net/andre/blog/2008/03/10/rdesktop-connect-to-windows-vista-with-cleartype-font-smoothing-enabled/

...is even more interesting in that it seems that one only needs to specify a custom experience flag to get this working. 
Comment 2 Peter Åstrand cendio 2009-12-01 09:35:35 CET
According to https://intranet.lkpg.cendio.se/tracker/issue9769, it works if one specifies -x 0x80 and installs the MS patches. 
Comment 3 Henrik Andersson cendio 2016-08-23 12:45:33 CEST
Upstream commit d952852, enables FontSmoothing per default.

https://github.com/rdesktop/rdesktop/commit/d952852629d9ed685eafbfe9304cabcb0cc68f20
Comment 4 Henrik Andersson cendio 2016-12-05 12:21:05 CET
Vendor drop in commit r31924 brings fix to enable font smoothing by default. Moving this bug to 4.8.0 release.
Comment 5 Henrik Andersson cendio 2016-12-06 07:31:32 CET
(In reply to comment #4)
> Vendor drop in commit r31924 brings fix to enable font smoothing by default.
> Moving this bug to 4.8.0 release.

Verified the difference using 4.7.0 rdesktop and nightly build 5310 against 2008r2 server. The login screen seems to always be fontsmoothed but you can se the obvious difference in textrendering when using notepad.
Comment 6 Thomas Nilefalk cendio 2016-12-06 15:14:51 CET
Created attachment 758 [details]
Side-by-side comparison of screenshots from Windows 2008R2 Server
Comment 7 Thomas Nilefalk cendio 2016-12-06 15:15:19 CET
Created attachment 759 [details]
Side-by-side comparison of screenshots from Windows 2012 Server
Comment 8 Thomas Nilefalk cendio 2016-12-06 15:17:23 CET
Verified smoothing difference between rdesktop 4.7.0 and 4.7.0-post 5310 on Windows 2008R2 Server and Windows 2012 Server. See attachments.
Comment 9 Thomas Nilefalk cendio 2016-12-06 16:21:56 CET
Created attachment 760 [details]
 Side-by-side comparison of screenshots from Windows 2008R2 Server
Comment 10 Thomas Nilefalk cendio 2016-12-06 16:22:43 CET
Created attachment 761 [details]
 Side-by-side comparison of screenshots from Windows 2012 Server
Comment 11 Henrik Andersson cendio 2017-03-08 16:37:00 CET
The vendor of rdesktop for this bug breaks seamless rdp, the actual commit upstream is 3140824be [1]. when seamlessrdp is used, geometry of the window is 100% of workarea and therfore g_sizeopt=-100 is used. However the commit changes this behaviour.


[1] https://github.com/rdesktop/rdesktop/pull/42/commits/3140824be37ee4f02adbb235209015ea796233f0
Comment 12 Henrik Andersson cendio 2017-03-09 12:24:16 CET
To reproduce the error, try launch a seamless rdp application like:

  ./rdesktop -A "%ProgramFiles%\ThinLinc\WTSTools\seamlessrdpshell.exe" -s   "notepad" tezava
  Autoselecting keyboard map 'en-us' from locale
  warning: unable to open /etc/gssapi_mech.conf: errno 2 (No such file or   directory)
  Connection established using SSL.
  Graphics(error): sec_process_crypt_info(), failed to parse crypt info
  X Error of failed request:  BadAlloc (insufficient resources for operation)
    Major opcode of failed request:  53 (X_CreatePixmap)
    Serial number of failed request:  46
    Current serial number in output stream:  54
Comment 14 Henrik Andersson cendio 2017-03-09 14:20:52 CET
Vendordrop fixes the seamlessrdp crash
Comment 15 Samuel Mannehed cendio 2017-03-10 15:01:25 CET
(In reply to comment #14)
> Vendordrop fixes the seamlessrdp crash

Works well. Tested with jenkins build 4.7.0post-5392.r32282

Note You need to log in before you can comment on or make changes to this bug.