Bugzilla – Bug 4071
Stop using and shipping HTMLgen
Last modified: 2014-10-06 15:45:17
You need to
before you can comment on or make changes to this bug.
Even with build 3260 we are still shipping and still using HTMLgen:
./share/browser_client/tlclient.cgi:from HTMLgen import *
./modules/thinlinc/tl_desktop/groups.py: from HTMLgen import TR , TD ,
TableLite , TH , Href , HR
tlclient.cgi will require a rewrite, but should not be too difficult.
I am unsure about tl_desktop/groups.py though. As far as I can see, the HTMLgen
import is in html_table_object, but this function is unused. Perhaps there are
also other unused functions here?
r29253 - rewrite of tlclient.cgi to get rid of HTMLgen
r29255 - removed displayurl
r29256 - formatting, trailing whitespace, linebreaks etc.
r29257 - removed the use of HTMLgen in groups.py
r29258 - removed HTMLgen from autotests, buildtools, docs and makefiles
r29259 - removed the HTMLgen library
(In reply to comment #2)
> r29255 - removed displayurl
Why? Need clarification.
(In reply to comment #3)
> (In reply to comment #2)
> > r29255 - removed displayurl
> Why? Need clarification.
After internal discussions we decided that displayurl could still potentially
be useful to users, its back in r29289.