Bug 4071 - Stop using and shipping HTMLgen
Summary: Stop using and shipping HTMLgen
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.2.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.3.0
Assignee: Samuel Mannehed
URL:
Keywords: astrand_tester, prosaic
Depends on:
Blocks:
 
Reported: 2011-11-24 14:20 CET by Peter Åstrand
Modified: 2014-10-06 15:45 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2011-11-24 14:20:28 CET 
Even with build 3260 we are still shipping and still using HTMLgen:

./share/browser_client/tlclient.cgi:from HTMLgen import *
./modules/thinlinc/tl_desktop/groups.py:  from HTMLgen import TR , TD , TableLite , TH , Href , HR

tlclient.cgi will require a rewrite, but should not be too difficult. 

I am unsure about tl_desktop/groups.py though. As far as I can see, the HTMLgen import is in html_table_object, but this function is unused. Perhaps there are also other unused functions here?
Comment 1 Samuel Mannehed cendio 2014-08-14 17:17:02 CEST 
r29253 - rewrite of tlclient.cgi to get rid of HTMLgen
Comment 2 Samuel Mannehed cendio 2014-08-15 11:32:35 CEST 
r29255 - removed displayurl
r29256 - formatting, trailing whitespace, linebreaks etc.
r29257 - removed the use of HTMLgen in groups.py
r29258 - removed HTMLgen from autotests, buildtools, docs and makefiles
r29259 - removed the HTMLgen library
Comment 3 Peter Åstrand cendio 2014-08-25 10:02:58 CEST 
(In reply to comment #2)
> r29255 - removed displayurl

Why? Need clarification.
Comment 4 Samuel Mannehed cendio 2014-08-27 14:16:50 CEST 
(In reply to comment #3)
> (In reply to comment #2)
> > r29255 - removed displayurl
> 
> Why? Need clarification.

After internal discussions we decided that displayurl could still potentially be useful to users, its back in r29289.
Comment 5 Peter Åstrand cendio 2014-09-22 14:22:10 CEST 
Fine now.
Note You need to log in before you can comment on or make changes to this bug.