Bug 7093 - Provide client performance measurements
Summary: Provide client performance measurements
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Pierre Ossman
URL:
Keywords: upstream
Depends on:
Blocks:
 
Reported: 2017-12-18 14:25 CET by Peter Åstrand
Modified: 2019-12-16 12:26 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Peter Åstrand cendio 2017-12-18 14:25:10 CET
The upstream vncviewer now has a very nice performance statistics graph. It would be nice if it could be available to ThinLinc users as well. For this, at least 2 things are needed:

1) Need to vendor drop upstream master 7cb4f31f6290df318962226bb35f60d0e2fd975c (2017-02-24 or later), or cherry pick this work. 

2) Provide a way of activating this graph, through tlclient command line and/or GUI.

Unfortunately, the only way of activating this in vncviewer is to run with loglevel 100, which might be too much. See upstream report: https://github.com/TigerVNC/tigervnc/issues/561

Also, currently we do not change the vncviewer loglevel based on the tlclient level (which is strange, because we do this for most or all other subprocesses).
Comment 2 Pierre Ossman cendio 2017-12-19 14:13:17 CET
We need some more details on the use cases here. What kind of monitoring or debugging are the customers trying to do? We've had one customer try this out, so we can follow up with them how useful it was for them.
Comment 3 Peter Åstrand cendio 2017-12-20 14:06:44 CET
New build of trunk with this feature is now available from:

https://www.cendio.com/~astrand/thinlinc/b7093

(but no directory listing due to SELinux).

It is activated by running "tlclient -d4".

Trunk was patched by running:

<cd Tigervnc>
$ git diff master@{2017-02-08}..7cb4f31f6290df318962226bb35f60d0e2fd975c > 
~/foo.patch

<cd ctc>
$ patch -N -F3 -p1 < ~/foo.patch

One conflict had to be resolved manually.
Comment 4 Peter Åstrand cendio 2018-02-06 13:22:40 CET
The dev meeting has decided that this is a useful feature, which we should add. However, we need to think a little bit more on how it should be activated (ie use -d4 or some other solution). We also need to write at least some basic documentation.
Comment 6 Pierre Ossman cendio 2019-12-10 12:56:41 CET
We will not be rolling this out as is. The current graph is too low level to be useful and will probably mislead more than it helps.

We need more tangible information about the needs here before we can start looking at how we can provide useful measurements.

Note You need to log in before you can comment on or make changes to this bug.