www.cendio.com
Bug 7279 - remove rdesktop (and associated tools)
: remove rdesktop (and associated tools)
Status: CLOSED FIXED
: ThinLinc
| rdesktop (deprecated)
: 1.3.1
: PC Unknown
: P2 Normal
: 4.10.0
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2018-11-19 11:59 by
Modified: 2019-02-25 17:24 (History)
Acceptance Criteria:
• There should be nothing left of rdesktop in the product or source tree • There should be nothing left of the rdesktop support programs and libraries in the product or the source tree • The rdesktop package should be removed when upgrading ThinLinc • The installer should show rdesktop being removed • All rdesktop bugzilla entries should be marked as WONTFIX • The rdesktop bugzilla component should be marked as deprecated • STRETCH: support programs should be made generic and included with upstream rdesktop where appropriate • There should be nothing left of tl-run-unixapp and supporting programs and libraries in the product or the source tree


Attachments


Note

You need to log in before you can comment on or make changes to this bug.


Description From cendio 2018-11-19 11:59:36
We are focusing on Linux desktops and want to remove the burden of maintaining
infrastructure for Windows desktops. As such we are removing rdesktop and all
associated tools and libraries from ThinLinc.

As part of this we are also removing tl-run-unixapp as it is also not part of
our focus, and doing so allows us to completely remove the "application server
group" concept.
------- Comment #1 From cendio 2018-11-19 12:01:47 -------
We do not have a list of all the components that can be removed as part of
this, so part of the work is figuring that out.
------- Comment #11 From cendio 2019-02-07 15:45:25 -------
rdesktop (and associated tools) is being removed from the ThinLinc product.
------- Comment #12 From cendio 2019-02-07 16:26:23 -------
Ignore the above comment. It was accidentally done as part of closing all
rdesktop things in the bugzilla.
------- Comment #18 From cendio 2019-02-11 09:37:32 -------
Debian doesn't seem to have a direct equivalent of RPMs "Obsoletes". Will need
to experiment a bit to find something that works.
------- Comment #19 From cendio 2019-02-12 09:31:29 -------
So the equivalent of RPM's obsoletes is using _both_ Replaces: and Conflicts:

https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces

Using just Replaces only indicates a partial replacement of a package.


Unfortunately this only almost works as there seems to be a bug in dpkg. It
realises that the new tlmisc obsoletes rdesktop and wants to remove rdesktop.
However when doing so it sees that the old tlmisc package depends on rdesktop
and bails. For some reason it fails to notice that the new tlmisc no longer has
that dependency. It does pay attention to new Provides: though, so adding a
"Provides: thinlinc-rdesktop" in the new tlmisc package gets everything
working.

(It is also possible to force your way through the issue using --force-depends
or --ignore-depends.)
------- Comment #20 From cendio 2019-02-12 09:32:22 -------
We're also lacking handling of obsolete mechanisms in the installer, so there
is no information about packages being removed there. We should probably fix
that as well.
------- Comment #27 From cendio 2019-02-13 14:14:11 -------
> • There should be nothing left of rdesktop in the product or source tree
>     • There should be nothing left of the rdesktop support programs and libraries in the product or the source tree

Not as far as I can find. I've done various searches for Windows and RDP
related words.

>     • The rdesktop package should be removed when upgrading ThinLinc

Works. Tested on Fedora 28, RHEL 7, Ubuntu 16.04 and 18.04.

>     • The installer should show rdesktop being removed

It does indeed. Tested on both RPM and deb systems.

>     • All rdesktop bugzilla entries should be marked as WONTFIX

Fixed.

>     • The rdesktop bugzilla component should be marked as deprecated

Fixed.

>     • STRETCH: support programs should be made generic and included with upstream rdesktop where appropriate

I looked through the programs and could not really find anything worthwhile to
upstream. They were either very tiny additions, or something tied to running it
in ThinLinc.

>     • There should be nothing left of tl-run-unixapp and supporting programs and libraries in the product or the source tree

Fixed.
------- Comment #28 From cendio 2019-02-25 17:24:52 -------
> There should be nothing left of rdesktop in the product or source tree

Looks good, all gone.

> There should be nothing left of the rdesktop support programs and libraries in the product or the source tree

Can't find anything remaining.

> The rdesktop package should be removed when upgrading ThinLinc

Works well. Verified on Ubuntu 16.04 and Fedora 29.

> The installer should show rdesktop being removed

The installer shows a separate section for packages that are being removed.
Good enough.

> All rdesktop bugzilla entries should be marked as WONTFIX

Looks good.

> The rdesktop bugzilla component should be marked as deprecated

Yep.

> STRETCH: support programs should be made generic and included with upstream rdesktop where appropriate

No, but see comment #27

> There should be nothing left of tl-run-unixapp and supporting programs and libraries in the product or the source tree

Looks good, all gone.