Bug 7477 - Session logging lacks important details
Summary: Session logging lacks important details
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.12.0
Assignee: Pierre Ossman
URL:
Keywords: aleta_tester, prosaic
Depends on: 5693
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-10 09:23 CET by Pierre Ossman
Modified: 2020-03-20 10:37 CET (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2020-03-10 09:23:42 CET
When troubleshooting it would be helpful to see the flow of sessions from the vsmserver log. It does log things (mostly), but it lacks details such as which display which makes it difficult to properly piece things together.

E.g.:

> 2020-03-09 13:30:47 INFO vsmserver.session: User with uid 2000 (testcustomer01) requested a new session
> 2020-03-09 13:30:49 INFO vsmserver: VSM Agent 127.0.0.1 successfully created a new session for testcustomer01
> 2020-03-09 13:31:08 INFO vsmserver.session: Session 127.0.0.1:11 for testcustomer01 has terminated. Removing.

This becomes extra important if the system is allowing multiple sessions per user.
Comment 5 Pierre Ossman cendio 2020-03-10 11:33:49 CET
Seems to work well. Need to test:

 * New session
 * Reconnect session
 * Kill session
 * Shadow session
 * Reconnect to dead session
 * Schedules detection of dead session
Comment 6 Alex Tanskanen cendio 2020-03-20 10:37:27 CET
Tested what was mentioned in comment #5 on build 6420 for RHEL8 and the vsmserver.log seems to always include the username (or uid), agent host and display number for each scenario.

The commits associated with this bug also changed the log output for warnings, e.g., if the session is killed with an unknown state. It's quite hard to actually get these warnings so I checked the code that generate the log to make sure that it logs display and agent. 

The log is much better and easier to follow now so this bug can be closed.

Note You need to log in before you can comment on or make changes to this bug.