Bugzilla – Bug 6152
Web Access keyboard code is needlessly complex
Last modified: 2018-02-14 09:23:55
You need to
before you can comment on or make changes to this bug.
The HTML keyboard code is very complex and fragile, making it difficult to do
any fixes or improvements to it. It has several problems:
a) It is overly abstracted, with a complex pipeline model even though the
steps in the pipeline are fixed. The steps aren't even independent of each
b) The code has grown organically as a series of individual fixes and lacks an
c) Large parts of the code is there to deal with old browsers that aren't in
use and do not fulfil noVNC's other requirements anyway.
A major cleanup is needed.
One symptom of this is that when fixing support for Unicode characters (needed
for many virtual keyboards), Enter and Backspace on IE/Edge stopped working:
(In reply to comment #1)
> One symptom of this is that when fixing support for Unicode characters (needed
> for many virtual keyboards), Enter and Backspace on IE/Edge stopped working:
The code that caused this was reverted in r32158.
When the PR below is merged and we are going to include it in thinlinc, we need
to revert the above commit.
We decided to not do this right now.
(In reply to comment #2)
This PR seems to solve most of the issues in bug 5135, reducing them to just a
handful specific things.
The PR mentioned here has been merged upstream.